Loading game assets direcly from CD/ISO without installing #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d5f6d3 to
b7b2420
Compare
| SPDLOG_LOGGER_CALL(spdlog::get("filesystem"), spdlogLevel, "cdio: {}", message); | ||
| } | ||
|
|
||
| void unshield_log_handler([[maybe_unused]] void* userdata, int level, const char* file, int line, const char* format, va_list args) |
Contributor
There was a problem hiding this comment.
[clang-format] reported by reviewdog 🐶
Suggested change
| void unshield_log_handler([[maybe_unused]] void* userdata, int level, const char* file, int line, const char* format, va_list args) | |
| void unshield_log_handler([[maybe_unused]] void* userdata, int level, const char* file, int line, const char* format, | |
| va_list args) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load game assets from CD using libcdio and from the installshield cabinet files inside using unshield.
The loading speed is not great due to the fact that it's extracting while loading, but it's not horrible.
This change can make it easier for non-windows users (especially restricted sandboxes such as with mobile and web) to run openblack using a single file (drag drop, file dialog).
TODO:
Depends on:
Closes #280