Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Change request to allow more characters in select#2

Merged
langecode merged 4 commits intoopenapi-tools:masteropenapi-tools/api-capabilities:masterfrom
Trackunit:masterTrackunit/api-capabilities:masterCopy head branch name to clipboard
Aug 15, 2019
Merged

Change request to allow more characters in select#2
langecode merged 4 commits intoopenapi-tools:masteropenapi-tools/api-capabilities:masterfrom
Trackunit:masterTrackunit/api-capabilities:masterCopy head branch name to clipboard

Conversation

@gringostar
Copy link
Collaborator

@gringostar gringostar commented Jul 10, 2019

Changes:

  • Changed select logic to allow more characters in 'value' part
  • Added wildcards to select syntax, to accommodate searching by partial strings
  • Updated readme to reflect actual implementation (alternatively the implementation should be changed to allow <attribute>+/-)

@gringostar
Copy link
Collaborator Author

Hi @langecode and @AllanHoejgaardJensen

Have you had a chance to review this PR?

Best regards
Niels

Copy link
Member

@langecode langecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Thanks for the contribution and the included clean ups. I will just let @AllanHoejgaardJensen have a few more day to take a look then I will merge.

@gringostar
Copy link
Collaborator Author

I think it looks good. Thanks for the contribution and the included clean ups. I will just let @AllanHoejgaardJensen have a few more day to take a look then I will merge.

Hi
Do you think it is OK to merge this PR now?

@langecode langecode merged commit 6749c09 into openapi-tools:master Aug 15, 2019
@langecode
Copy link
Member

@gringostar I will make a release latest in the weekend. Thanks for othe contribution.

@langecode
Copy link
Member

Published as v1.0.3 - sorry for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.