Allow arguments to be passed to files list request #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iBotPeaches
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
good catch. I peeked our tests and didn't see anything that we could augment for this detection in future. The variability of incoming parameters to support changes makes the testing of such a thing not there so not sure we could have caught functions that should have parameters vs not.
+1
|
@iBotPeaches can you add tests on this? |
Yeah I'll take a stab at it tomorrow. Trying to think of an elegant approach, maybe spying the transporter to see if it sets what we expect. |
iBotPeaches
approved these changes
Apr 14, 2025
2 tasks
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
From a discussion on Twitter...
TL;DR:
You can't currently pass parameters to the files list request, which means you can only ever get the first 10. This PR adds the ability to paginate, change limit etc.
Unrelated: the refactor commands in readme don't appear to work. Everything else passed.
Related:
fixes: #500