Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: chat completion choices to allow responses without logprobs field #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TyperEJ
Copy link
Contributor

@TyperEJ TyperEJ commented Apr 11, 2025

What:

  • Bug Fix
  • New Feature

Description:

As it has been some time since I last forked the repository, I noticed from OpenAI's documentation that the chat completion's 'choices' now includes a 'logprobs' field. However, Google Gemini's OpenAI compatibility layer doesn't yet support this field. Therefore, I've modified the code to allow chat completion 'choices' to function without requiring the 'logprobs' field.

Related:

fixes: #502

@iBotPeaches iBotPeaches added bug Something isn't working Non-OpenAI Model Not an OpenAI Model. labels Apr 11, 2025
@iBotPeaches iBotPeaches merged commit ad7743d into openai-php:main Apr 11, 2025
10 checks passed
@iBotPeaches
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Non-OpenAI Model Not an OpenAI Model.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.