Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix type definition for responses in ClientFake::addResponses method #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025

Conversation

ovitores
Copy link
Contributor

@ovitores ovitores commented Apr 24, 2024

What:

Description:

Fix type definition in ClientFake::addResposnses() method to avoid messages from IDE advertising thhat objects passed are of different type

@DjordyKoert
Copy link

any update on when this fix can be expected to be merged?

@ovitores
Copy link
Contributor Author

Fix #513

Copy link
Collaborator

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. I was going to merge this, but it fails composer test:lint.

@ovitores ovitores requested a review from iBotPeaches April 7, 2025 08:49
@iBotPeaches iBotPeaches merged commit 5740fce into openai-php:main Apr 7, 2025
10 checks passed
@iBotPeaches
Copy link
Collaborator

thanks!

@iBotPeaches iBotPeaches added the bug Something isn't working label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type definition for responses in ClientFake::addResponses method
3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.