Added mcp 'instructions' attribute to the server #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm-openai
requested changes
May 16, 2025
src/agents/mcp/server.py
Outdated
| @@ -122,7 +123,8 @@ async def connect(self): | ||
| else None, | ||
| ) | ||
| ) | ||
| await session.initialize() | ||
| server_result = await session.initialize() | ||
| self.instructions = getattr(server_result, "instructions", None) |
There was a problem hiding this comment.
why use getattr? I see initialize() returns types.InitializeResult, which has instructions: str | None = None
In fact, we should probably just set self.server_initialize_result. That way devs can read other info too, e.g. protocol version or capabilities
There was a problem hiding this comment.
As you prefer, the issue was about instructions so I read that value, but now I set the variable as you suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
instructionsattribute to the MCP servers to solve #704 .Let me know if you want to add an example to the documentation.