Update data models#91
Merged
nathansalter merged 5 commits intomasteropenactive/models-php:masterfrom Apr 8, 2022
Merged
Conversation
Contributor
|
Looks like the test for this has been wrong since we switched to string prices (before switching them back). At this point I guess the test wasn't updated back to what it should have been. Further note; the |
nickevansuk
approved these changes
Apr 6, 2022
Contributor
nickevansuk
left a comment
There was a problem hiding this comment.
Assuming that this is primarily property reordering, LGTM!
79c517d to
fa75857
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update PHP data models to the latest version based on the OpenActive Vocabulary (codified by the Data Models), Test Interface and Beta Namespace.