Feature/aggregate facility use modifier#109
Merged
nathansalter merged 16 commits intoopenactive:masteropenactive/models-php:masterfrom Jun 30, 2023
drinkynet:feature/aggregate-facility-use-modifierdrinkynet/models-php:feature/aggregate-facility-use-modifierCopy head branch name to clipboard
Merged
Feature/aggregate facility use modifier#109nathansalter merged 16 commits intoopenactive:masteropenactive/models-php:masterfrom drinkynet:feature/aggregate-facility-use-modifierdrinkynet/models-php:feature/aggregate-facility-use-modifierCopy head branch name to clipboard
nathansalter merged 16 commits intoopenactive:masteropenactive/models-php:masterfrom
drinkynet:feature/aggregate-facility-use-modifierdrinkynet/models-php:feature/aggregate-facility-use-modifierCopy head branch name to clipboard
Conversation
…d not be present on Order objects when they are in the Orders RPDE feed. Also add a test case to check it works.
Contributor
Author
|
I seem to have done this in a weird way, all but one of the commits in this branch are in this earlier one: #108 |
Switch to the SSH rather than HTTPS clone method in the contributing section
Update README.md
nathansalter
requested changes
Jun 30, 2023
Contributor
nathansalter
left a comment
There was a problem hiding this comment.
Good work so far, just requires a few small changes
tests/Unit/Modifiers/AggregateFacilityUseProviderModifierTest.php
Outdated
Show resolved
Hide resolved
nathansalter
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a modifier to remove the provider from aggregateFacilityUse properties