Add OrdersFeedModifer#104
Merged
nathansalter merged 8 commits intoopenactive:masteropenactive/models-php:masterfrom Jun 27, 2022
Merged
Add OrdersFeedModifer#104nathansalter merged 8 commits intoopenactive:masteropenactive/models-php:masterfrom
nathansalter merged 8 commits intoopenactive:masteropenactive/models-php:masterfrom
Conversation
…d not be present on Order objects when they are in the Orders RPDE feed. Also add a test case to check it works.
Contributor
Author
|
Forgot about PHP 5.6 it doesn't like the : Order return type on the getTestOrder() method. |
nathansalter
requested changes
Jun 27, 2022
Contributor
nathansalter
left a comment
There was a problem hiding this comment.
I've made a couple of comments on the tests, otherwise this looks good! Just one thing, if you could edit your commit to shorten the commit line, that would be great. e.g.
Add OrdersFeedModifer
Adds an OrdersFeedModifier that filters out Order elements that should not be
present on Order objects when they are in the Orders RPDE feed. Also adds a
test case to check this.
nathansalter
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an OrdersFeedModifier that filters out Order elements that should not be
present on Order objects when they are in the Orders RPDE feed. Also adds a
test case to check this.