Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Consolidated packages#192

Open
MarkCiliaVincenti wants to merge 4 commits intoopenactive:masteropenactive/OpenActive.Server.NET:masterfrom
MarkCiliaVincenti:ConsolidationsMarkCiliaVincenti/OpenActive.Server.NET:ConsolidationsCopy head branch name to clipboard
Open

Consolidated packages#192
MarkCiliaVincenti wants to merge 4 commits intoopenactive:masteropenactive/OpenActive.Server.NET:masterfrom
MarkCiliaVincenti:ConsolidationsMarkCiliaVincenti/OpenActive.Server.NET:ConsolidationsCopy head branch name to clipboard

Conversation

@MarkCiliaVincenti
Copy link

Please note that some other packages are marked as having vulnerabilities and should be updated.

@MarkCiliaVincenti
Copy link
Author

@nickevansuk can you check if CI works with this?

@MarkCiliaVincenti
Copy link
Author

@nickevansuk ?

@MarkCiliaVincenti
Copy link
Author

So all I did here was open VS2022, opened "Manage NuGet Packages for Solution", went on the Consolidate tab and consolidated 2 packages. CI should really not be failing here.

@nickevansuk
Copy link
Contributor

.NET Framework is indeed fickle

@MarkCiliaVincenti
Copy link
Author

.NET Framework is indeed fickle

Are you entirely sure that the current build passes CI? Could the problem be with the CI rather than the code changes?

@nickevansuk
Copy link
Contributor

It's possible something else is broken here for sure - will add it to the backlog to investigate

@nickevansuk nickevansuk self-assigned this Jan 23, 2023
@MarkCiliaVincenti
Copy link
Author

It's possible something else is broken here for sure - will add it to the backlog to investigate

Probably this commit: 119c30e

@nickevansuk nickevansuk removed their assignment Feb 1, 2023
@MarkCiliaVincenti
Copy link
Author

@nickevansuk I see you removed your assignment yesterday; did you figure out the issue?

@nickevansuk
Copy link
Contributor

Not yet - that was just as it's on the backlog. Hoping to get some time to look at this in the next couple of weeks so will keep you posted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋 Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.