Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Provide stack trace filtering in context #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from

Conversation

essell
Copy link

@essell essell commented May 13, 2024

Filters stack traces in both log text and context since they mostly end up here.

@essell
Copy link
Author

essell commented May 13, 2024

Tests successful using composer test as well as in dependent Laravel project.

@arukompas
Copy link
Contributor

hey @essell , thanks for the PR!

Do you think we could have a test for this use case? One to make sure a stack trace within a context string gets filtered, and another to make sure non-stack, multiline context strings don't get affected.

@essell
Copy link
Author

essell commented May 17, 2024

hey @essell , thanks for the PR!

Do you think we could have a test for this use case? One to make sure a stack trace within a context string gets filtered, and another to make sure non-stack, multiline context strings don't get affected.

@arukompas Sure! FYI, the changes I submitted only look through the first level of the context array for stack trace filtering, and doesn't recurse into it deeper. I suspect that it's a rare use case to stick the trace deep into a sub-array, so I opted for simplicity.

@arukompas
Copy link
Contributor

hey @essell , is this PR still relevant, or have you changed your mind about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.