Fix lipgloss padding on long CLI error messages#2332
Open
holyfuchs wants to merge 1 commit intomasteronflow/flow-cli:masterfrom
holyfuchs/improve-test-error-outputonflow/flow-cli:holyfuchs/improve-test-error-outputCopy head branch name to clipboard
Open
Fix lipgloss padding on long CLI error messages#2332holyfuchs wants to merge 1 commit intomasteronflow/flow-cli:masterfrom holyfuchs/improve-test-error-outputonflow/flow-cli:holyfuchs/improve-test-error-outputCopy head branch name to clipboard
holyfuchs wants to merge 1 commit intomasteronflow/flow-cli:masterfrom
holyfuchs/improve-test-error-outputonflow/flow-cli:holyfuchs/improve-test-error-outputCopy head branch name to clipboard
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2331
Summary
When
handleErrorpasses a multi-line error message through lipgloss'sRender, lipgloss normalizes every line to the width of the longest line, producing hundreds of trailing spaces that make the output completely unreadable.This was most visible with
flow testassertion failures containing a full Cadence transaction error chain serialized with literal\nsequences.Fix
Added
renderErrorMsgwhich:\nsequences (common in serialized Cadence runtime errors)branding.ErrorStyle.Render(line)— passing a multiline block to lipgloss triggers the padding behavior, but single lines are safeAll
errorMessageStyle.Render(...)calls inhandleErrornow go through this function. The unusederrorMessageStyleanddescriptionStylevars were also removed.