Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Should umfPutIPCHandle and umfOpenIPCHandle take const handle data pointers? #1536

Copy link
Copy link
@steffenlarsen

Description

@steffenlarsen
Issue body actions

Rationale

umfPutIPCHandle and umfOpenIPCHandle currently take an umf_ipc_handle_t, but since the handles are replicable across processes I would not expect these functions to change the data contained in the handles. Could these be changed to take const handles?

API Changes

Change from

umf_result_t umfPutIPCHandle(umf_ipc_handle_t ipcHandle);
umf_result_t umfOpenIPCHandle(umf_ipc_handler_handle_t hIPCHandler, umf_ipc_handle_t ipcHandle, void **ptr)

to

typedef const struct umf_ipc_data_t *umf_const_ipc_handle_t;

umf_result_t umfPutIPCHandle(umf_const_ipc_handle_t ipcHandle);
umf_result_t umfOpenIPCHandle(umf_ipc_handler_handle_t hIPCHandler, umf_const_ipc_handle_t ipcHandle, void **ptr)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.