add initialization for d_a#1622
Closed
ChengChen002 wants to merge 1 commit intooneapi-src:masteroneapi-src/oneAPI-samples:masterfrom
ChengChen002:masterCopy head branch name to clipboard
Closed
add initialization for d_a#1622ChengChen002 wants to merge 1 commit intooneapi-src:masteroneapi-src/oneAPI-samples:masterfrom ChengChen002:masterCopy head branch name to clipboard
ChengChen002 wants to merge 1 commit intooneapi-src:masteroneapi-src/oneAPI-samples:masterfrom
ChengChen002:masterCopy head branch name to clipboard
Conversation
Contributor
Author
|
@ManjulaChalla Could you help to review and merge this PR when free, thanks. |
IgorOchocki
reviewed
May 9, 2023
Contributor
IgorOchocki
left a comment
There was a problem hiding this comment.
Is there any reason this is fix is supposed to be merged into the master branch instead of development?
Contributor
Author
Sorry, I'm not familiar with the commit rules for this repository, should I submit a PR to the development branch? |
Contributor
Author
|
Changed branch which I want to merge the PR into from master to development, see the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variables "d_a" are not initialized, so the result during reduction is uncertain and may overflow to a negative number, causing the test to fail.