Conditionally use ament_cmake to register package for colcon workspaces environment #884
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to properly regester colcon package E.g. set AMENT_CURRENT_PREFIX environment
Contributor
Author
|
This isn't quite working yet, as downstream packages still can't find the path for ompl's include headerfiles. Conditionally swapping between a native cmake build_type to a ament_cmake build_type is bit advanced for my CMake-foo, so suggestions welcome. |
Member
|
Is it perhaps this code that needs to change for downstream packages?: https://github.com/ompl/ompl/blob/main/CMakeLists.txt#L202-L217 |
to setup ament_generate_package_environment and let native cmake handle the include export
Contributor
|
The recent CMake changes to support target-based properties on ompl should make this easier. |
Contributor
|
@ruffsl Can you confirm this is still an issue for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883 by mimicking the approach from BehaviorTree.CPP to conditionally use ament_cmake.