-
-
Notifications
You must be signed in to change notification settings - Fork 26.3k
refactor(git)!: Update alias and function deprecations #13149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rivenirvana
wants to merge
5
commits into
ohmyzsh:master
Choose a base branch
from
rivenirvana:rm-deprecated-git-aliases
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd24941
to
b0f4115
Compare
de480ae
to
31cfd38
Compare
31cfd38
to
62df87a
Compare
62df87a
to
cfe6cc6
Compare
cfe6cc6
to
5e67980
Compare
5e67980
to
9bc46dc
Compare
Is nobody interested in this change? |
9bc46dc
to
43d5c83
Compare
e14f424
to
3158780
Compare
29802a1
to
dc815f9
Compare
dc815f9
to
8213a39
Compare
ea3a61a
to
532d51f
Compare
67e90f5
to
c87d340
Compare
c87d340
to
817dc72
Compare
32803f0
to
63eab96
Compare
700728a
to
ac8bf76
Compare
… alternative functions
There are some aliases, whose functionality has long been reassigned to different aliases, but have not been reused for new commands, yet are still documented in the README. Remove them.
ac8bf76
to
7b9b513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: plugin
Issue or PR related to a plugin
Topic: alias
Pull Request or issue regarding aliases
Type: documentation
Documentation issue or Pull Request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standards checklist:
Changes:
git pull --rebase
aliasesggpull
/ggpur
/ggpush
for their alternative functionscurrent_branch
function in favor of what's in coreOther comments:
I'm gonna be honest, I only wanted to just be able to use gup without
unalias
-ing it first in my zshrc. But the code for deprecation warnings seemed like a waste to just remove, and after taking a look it felt like some parts needed updates too, so why not make use of it so we can proceed with a system where we can actually transition functionalities from soft deprecation to removal? Some of these have been sitting here for a while now, after all (>2 years). Appreciate any feedback/conversation regarding this.