Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

rivenirvana
Copy link

@rivenirvana rivenirvana commented Jun 1, 2025

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Remove deprecated git pull --rebase aliases
  • Start deprecating ggpull/ggpur/ggpush for their alternative functions
  • Start deprecating current_branch function in favor of what's in core
  • Update README to reflect above changes and undocument some long-removed aliases

Other comments:

I'm gonna be honest, I only wanted to just be able to use gup without unalias-ing it first in my zshrc. But the code for deprecation warnings seemed like a waste to just remove, and after taking a look it felt like some parts needed updates too, so why not make use of it so we can proceed with a system where we can actually transition functionalities from soft deprecation to removal? Some of these have been sitting here for a while now, after all (>2 years). Appreciate any feedback/conversation regarding this.

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases Type: documentation Documentation issue or Pull Request labels Jun 1, 2025
@ohmyzsh ohmyzsh bot added this to Main project Jun 1, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Main project Jun 1, 2025
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from dd24941 to b0f4115 Compare June 10, 2025 02:17
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch 2 times, most recently from de480ae to 31cfd38 Compare June 21, 2025 01:57
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from 31cfd38 to 62df87a Compare June 26, 2025 13:40
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from 62df87a to cfe6cc6 Compare July 11, 2025 05:23
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from cfe6cc6 to 5e67980 Compare July 21, 2025 11:20
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from 5e67980 to 9bc46dc Compare August 9, 2025 10:54
@rivenirvana
Copy link
Author

Is nobody interested in this change?

@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from 9bc46dc to 43d5c83 Compare August 12, 2025 15:24
@rivenirvana rivenirvana changed the title git: Update alias and function deprecations refactor(git)!: Update alias and function deprecations Aug 13, 2025
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch 3 times, most recently from e14f424 to 3158780 Compare August 20, 2025 11:37
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch 2 times, most recently from 29802a1 to dc815f9 Compare September 2, 2025 06:52
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from dc815f9 to 8213a39 Compare September 5, 2025 07:51
@carlosala carlosala requested a review from mcornella September 6, 2025 04:31
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch 3 times, most recently from ea3a61a to 532d51f Compare September 10, 2025 03:34
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch 3 times, most recently from 67e90f5 to c87d340 Compare September 26, 2025 03:40
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from c87d340 to 817dc72 Compare September 28, 2025 08:14
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch 2 times, most recently from 32803f0 to 63eab96 Compare October 5, 2025 14:49
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch 2 times, most recently from 700728a to ac8bf76 Compare October 11, 2025 05:23
There are some aliases, whose functionality has long been reassigned to
different aliases, but have not been reused for new commands, yet are
still documented in the README. Remove them.
@rivenirvana rivenirvana force-pushed the rm-deprecated-git-aliases branch from ac8bf76 to 7b9b513 Compare October 14, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases Type: documentation Documentation issue or Pull Request

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.