fix(deps): add explicit dependency on @octokit/webhooks
#2847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way that the types are defined, the `App` class definition created with `App#defaults()` contains references to `@octokit/webhooks`. Adds an explicit dependency on `@octokit/webhooks` to avoid any issue for consumers. Fixes #2844
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
oscard0m
approved these changes
May 20, 2025
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I will backport this to previous versions where needed |
wolfy1339
added a commit
that referenced
this pull request
May 20, 2025
Because of the way that the types are defined, the `App` class definition created with `App#defaults()` contains references to `@octokit/webhooks`. Adds an explicit dependency on `@octokit/webhooks` to avoid any issue for consumers. Fixes #2844
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 24, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 5.0.2 | ## [v5.0.2](https://github.com/octokit/octokit.js/releases/tag/v5.0.2) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2853](octokit/octokit.js#2853)) ([edfce61](octokit/octokit.js@edfce61)) ## [v5.0.1](https://github.com/octokit/octokit.js/releases/tag/v5.0.1) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([2b5ed09](octokit/octokit.js@2b5ed09)), closes [#2844](octokit/octokit.js#2844) ## [v5.0.0](https://github.com/octokit/octokit.js/releases/tag/v5.0.0) ##### Continuous Integration - stop testing against NodeJS v18 ([#2846](octokit/octokit.js#2846)) ([8ec7ed7](octokit/octokit.js@8ec7ed7)) ##### BREAKING CHANGES - Drop support for NodeJS v18 - ci: stop testing against NodeJS v18 ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 24, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 5.0.2 | ## [v5.0.2](https://github.com/octokit/octokit.js/releases/tag/v5.0.2) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2853](octokit/octokit.js#2853)) ([edfce61](octokit/octokit.js@edfce61)) ## [v5.0.1](https://github.com/octokit/octokit.js/releases/tag/v5.0.1) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([2b5ed09](octokit/octokit.js@2b5ed09)), closes [#2844](octokit/octokit.js#2844) ## [v5.0.0](https://github.com/octokit/octokit.js/releases/tag/v5.0.0) ##### Continuous Integration - stop testing against NodeJS v18 ([#2846](octokit/octokit.js#2846)) ([8ec7ed7](octokit/octokit.js@8ec7ed7)) ##### BREAKING CHANGES - Drop support for NodeJS v18 - ci: stop testing against NodeJS v18 ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 24, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 4.1.4 | ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 25, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 5.0.2 | ## [v5.0.2](https://github.com/octokit/octokit.js/releases/tag/v5.0.2) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2853](octokit/octokit.js#2853)) ([edfce61](octokit/octokit.js@edfce61)) ## [v5.0.1](https://github.com/octokit/octokit.js/releases/tag/v5.0.1) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([2b5ed09](octokit/octokit.js@2b5ed09)), closes [#2844](octokit/octokit.js#2844) ## [v5.0.0](https://github.com/octokit/octokit.js/releases/tag/v5.0.0) ##### Continuous Integration - stop testing against NodeJS v18 ([#2846](octokit/octokit.js#2846)) ([8ec7ed7](octokit/octokit.js@8ec7ed7)) ##### BREAKING CHANGES - Drop support for NodeJS v18 - ci: stop testing against NodeJS v18 ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 25, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 4.1.4 | ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 31, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 5.0.3 | ## [v5.0.3](https://github.com/octokit/octokit.js/releases/tag/v5.0.3) ##### Bug Fixes - **deps:** update dependency [@octokit/plugin-rest-endpoint-methods](https://github.com/octokit/plugin-rest-endpoint-methods) to v16 ([#2855](octokit/octokit.js#2855)) ([310e4cb](octokit/octokit.js@310e4cb)) ## [v5.0.2](https://github.com/octokit/octokit.js/releases/tag/v5.0.2) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2853](octokit/octokit.js#2853)) ([edfce61](octokit/octokit.js@edfce61)) ## [v5.0.1](https://github.com/octokit/octokit.js/releases/tag/v5.0.1) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([2b5ed09](octokit/octokit.js@2b5ed09)), closes [#2844](octokit/octokit.js#2844) ## [v5.0.0](https://github.com/octokit/octokit.js/releases/tag/v5.0.0) ##### Continuous Integration - stop testing against NodeJS v18 ([#2846](octokit/octokit.js#2846)) ([8ec7ed7](octokit/octokit.js@8ec7ed7)) ##### BREAKING CHANGES - Drop support for NodeJS v18 - ci: stop testing against NodeJS v18 ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 31, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 4.1.4 | ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jun 1, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 5.0.3 | ## [v5.0.3](https://github.com/octokit/octokit.js/releases/tag/v5.0.3) ##### Bug Fixes - **deps:** update dependency [@octokit/plugin-rest-endpoint-methods](https://github.com/octokit/plugin-rest-endpoint-methods) to v16 ([#2855](octokit/octokit.js#2855)) ([310e4cb](octokit/octokit.js@310e4cb)) ## [v5.0.2](https://github.com/octokit/octokit.js/releases/tag/v5.0.2) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2853](octokit/octokit.js#2853)) ([edfce61](octokit/octokit.js@edfce61)) ## [v5.0.1](https://github.com/octokit/octokit.js/releases/tag/v5.0.1) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([2b5ed09](octokit/octokit.js@2b5ed09)), closes [#2844](octokit/octokit.js#2844) ## [v5.0.0](https://github.com/octokit/octokit.js/releases/tag/v5.0.0) ##### Continuous Integration - stop testing against NodeJS v18 ([#2846](octokit/octokit.js#2846)) ([8ec7ed7](octokit/octokit.js@8ec7ed7)) ##### BREAKING CHANGES - Drop support for NodeJS v18 - ci: stop testing against NodeJS v18 ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jun 1, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 4.1.4 | ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jun 6, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 5.0.3 | ## [v5.0.3](https://github.com/octokit/octokit.js/releases/tag/v5.0.3) ##### Bug Fixes - **deps:** update dependency [@octokit/plugin-rest-endpoint-methods](https://github.com/octokit/plugin-rest-endpoint-methods) to v16 ([#2855](octokit/octokit.js#2855)) ([310e4cb](octokit/octokit.js@310e4cb)) ## [v5.0.2](https://github.com/octokit/octokit.js/releases/tag/v5.0.2) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2853](octokit/octokit.js#2853)) ([edfce61](octokit/octokit.js@edfce61)) ## [v5.0.1](https://github.com/octokit/octokit.js/releases/tag/v5.0.1) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([2b5ed09](octokit/octokit.js@2b5ed09)), closes [#2844](octokit/octokit.js#2844) ## [v5.0.0](https://github.com/octokit/octokit.js/releases/tag/v5.0.0) ##### Continuous Integration - stop testing against NodeJS v18 ([#2846](octokit/octokit.js#2846)) ([8ec7ed7](octokit/octokit.js@8ec7ed7)) ##### BREAKING CHANGES - Drop support for NodeJS v18 - ci: stop testing against NodeJS v18 ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jun 6, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 4.1.4 | ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jun 8, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 5.0.3 | ## [v5.0.3](https://github.com/octokit/octokit.js/releases/tag/v5.0.3) ##### Bug Fixes - **deps:** update dependency [@octokit/plugin-rest-endpoint-methods](https://github.com/octokit/plugin-rest-endpoint-methods) to v16 ([#2855](octokit/octokit.js#2855)) ([310e4cb](octokit/octokit.js@310e4cb)) ## [v5.0.2](https://github.com/octokit/octokit.js/releases/tag/v5.0.2) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2853](octokit/octokit.js#2853)) ([edfce61](octokit/octokit.js@edfce61)) ## [v5.0.1](https://github.com/octokit/octokit.js/releases/tag/v5.0.1) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([2b5ed09](octokit/octokit.js@2b5ed09)), closes [#2844](octokit/octokit.js#2844) ## [v5.0.0](https://github.com/octokit/octokit.js/releases/tag/v5.0.0) ##### Continuous Integration - stop testing against NodeJS v18 ([#2846](octokit/octokit.js#2846)) ([8ec7ed7](octokit/octokit.js@8ec7ed7)) ##### BREAKING CHANGES - Drop support for NodeJS v18 - ci: stop testing against NodeJS v18 ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jun 8, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | octokit | 4.1.2 | 4.1.4 | ## [v4.1.4](https://github.com/octokit/octokit.js/releases/tag/v4.1.4) ##### Bug Fixes - **deps:** add explicit dependency on `@octokit/webhooks` ([#2847](octokit/octokit.js#2847)) ([3589cd2](octokit/octokit.js@3589cd2)), closes [#2844](octokit/octokit.js#2844) ## [v4.1.3](https://github.com/octokit/octokit.js/releases/tag/v4.1.3) ##### Bug Fixes - **deps:** update octokit monorepo (major) ([#2836](octokit/octokit.js#2836)) ([4ccc6d3](octokit/octokit.js@4ccc6d3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way that the types are defined, the
Appclass definition created withApp#defaults()contains references to@octokit/webhooks.Adds an explicit dependency on
@octokit/webhooksto avoid any issue for consumers.Fixes #2844
Resolves #ISSUE_NUMBER
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!