Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

add irc support#2

Open
verymilan wants to merge 1 commit intooctacian:masteroctacian/chat3:masterfrom
verymilan:masterverymilan/chat3:masterCopy head branch name to clipboard
Open

add irc support#2
verymilan wants to merge 1 commit intooctacian:masteroctacian/chat3:masterfrom
verymilan:masterverymilan/chat3:masterCopy head branch name to clipboard

Conversation

@verymilan
Copy link
Copy Markdown

@verymilan verymilan commented Sep 28, 2018

because it became a bit quiet in the groupchats after adding chat3. :)
screenshot_20180928_124228

@octacian
Copy link
Copy Markdown
Owner

Thanks, I think someone had requested this a while back, but I never got to it.

Could you make one minor change though? It would probably be better to call minetest.get_modpath once, storing it somewhere around line 40 (probably as irc_available) and then referring to this variable in the conditionals. Should you be willing to do so, you need not worry about amending your commit, I can simply squash on merge.

Also, I assume it's impossible to send PMs between Minetest and IRC? (noticed you hadn't done anything with the /msg override.)

@Panquesito7
Copy link
Copy Markdown

Panquesito7 commented Aug 7, 2019

Also, I assume it's impossible to send PMs between Minetest and IRC? (noticed you hadn't done anything with the /msg override.)

AFAIK, IRC users can send private messages to MT players, and vice-versa.
BTW, maybe using mod.conf instead of depends.txt would be better.

@deezl
Copy link
Copy Markdown

deezl commented Aug 18, 2019

Curious why this was never merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.