Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

You can now select for the global filter to land at the end of a task #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Draft

You can now select for the global filter to land at the end of a task #462

wants to merge 2 commits into from

Conversation

DamnedScholar
Copy link

This should fix #147.

I had to update package.json to pin @types/jest to ^27.0.0 to resolve a dependency conflict on install. Every other change is directly related to the issue fix.

schemar
schemar requested changes Jan 2, 2022
View reviewed changes
Copy link
Collaborator

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove package-lock.json and use yarn instead. Yarn should also use the existing yarn.lock file where dependencies should have their correct versions.

@schemar
Copy link
Collaborator

schemar commented Jan 2, 2022

Thank you @DamnedScholar, looks very compact/nice 👍 I don't have much time right now, but I will have a look as soon as I do.

schemar
schemar reviewed Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn’t elaborate on that enough with my last comment. I think if you revert package.json and yarn.lock, then do a yarn install, everything should work. Or is that not the case?

@schemar schemar added the question Further information is requested label Feb 16, 2022
@schemar
Copy link
Collaborator

schemar commented Mar 27, 2022

@DamnedScholar you still have unrelated changes in your package.json and yarn.lock.

@sytone sytone mentioned this pull request May 23, 2022
Closed
7 tasks
@claremacrae
Copy link
Collaborator

Setting to draft status any PRs which are not currently mergable, but will be useful in future.

@claremacrae claremacrae marked this pull request as draft May 7, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schemar schemar schemar requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

question Further information is requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There should be an option to put the global filter at the end

3 participants

@DamnedScholar @schemar @claremacrae
Morty Proxy This is a proxified and sanitized view of the page, visit original site.