Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

SARIF needs a mechanism to denote an in-flight or completed suppressions review #348

Copy link
Copy link
@michaelcfanning

Description

@michaelcfanning
Issue body actions

Before a result is conclusively suppressed externally, there is a conversation about it. A result viewer might want to connect to and update (or simply start) that conversation.

The simplest way to provide for this is to define an additional suppressState 'underReview'. When decorated in this way, a viewer would not literally indicate the result is suppressed.

We could also consider renaming this construct to 'reviewAnnotation' etc. I tend to think the 'underReview' state is the simplest option at this late stage.

Separately, what if a conversation occurs but the result was not deemed to be suppressible? What suppression state could indicate this? 'acquitted'? 'determinedToBeTruePositive'?

Once we think about this final 'not a false positive' annotation, another term does occur to me 'dispositions' or 'evaluations'.

result.dispositions is an array of external conversations related to 'disposing' or 'evaluating' a result. 'suppressedExternally' or 'suppressedInSource' is a completed evalution.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.