Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MNT: Get rid of Pyflakes / flake8 #28976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft May 15, 2025 13:23
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review May 15, 2025 13:24
@charris
Copy link
Member

charris commented May 15, 2025

I assume these warnings don't appear with ruff? Is it a default thing?

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented May 15, 2025

I haven't really investigated why ruff doesn't show warnings. I suspect relevant warnings are disabled for these files:

"test*.py" = ["E201", "E714"]

EDIT: Rather, the equivalent ruff rule F841 is globally disabled:

"F841", # Local variable is assigned to but never used

I haven't applied it yet because the changes are extensive. It's part of the disabled rules that can be incrementally enabled in a dedicated PR - or not.

@charris charris merged commit 9a2ba98 into numpy:main May 16, 2025
75 checks passed
@charris
Copy link
Member

charris commented May 16, 2025

Thanks @DimitriPapadopoulos .

@DimitriPapadopoulos DimitriPapadopoulos deleted the Pyflakes_flake8 branch May 16, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.