MAINT: Enable linting with ruff E501 #28945
Merged
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we gradually start enforcing the maximum line length rules using ruff. In followup PRs (each one relatively small, could be done by new contributors) we can change the codebase step by step.
The numpy max line width has most recently been changed to 88 in MAINT: increase max line length from 79 to 88, upgrade pycodestyle #27320. Also see Linting Package Replacement: Pycodestyle to Ruff #24994 (comment)
The total number of max line length violations is quite large. We can reduce the number of changes by setting the ruff max-line-length to a larger value, but to me that only makes sense if we would consider increasing the official max line length value.
If the PR is accepted I will create a tracking issue for other contributors.
@charris
update: tracking issue is #28947