MNT: discard unused function using os.system() #28876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @DimitriPapadopoulos . Hmm, I suspect this whole file can be removed. It seems intended to provide system information when dealing with f2py failures. It also has a lot of code dealing with distutils, which is going away. |
|
Perhaps I shouldn't have removed this after all: Line 19 in 99e52b1 Isn't numpy.f2py.diagnose part of the public API?
Not that anyone is necessarily using it, but isn't it part of the API? Perhaps deprecate it first? |
Yes, and tested for that. The proper procedure to remove the whole file would be to deprecate first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.