More comprehensive testing

numpy · Tontonio3 · Apr 15, 2025 · Apr 15, 2025 · Apr 16, 2025 · Apr 16, 2025
commit 90be12ee5d7c00ea021e246ddbc0198fca0487c1
diff --git a/numpy/_core/src/common/npy_longdouble.c b/numpy/_core/src/common/npy_longdouble.c
@@ -112,7 +112,7 @@ npy_longdouble _int_to_ld(int64_t *val, int exp, int sign) {
    for (int i = 0; i < 3; i++) { mantissa[i] = (uint64_t)val[i]; }
    npy_longdouble ld;
    if (exp == 0) {
-        ld = mantissa[0];
+        ld = (npy_longdouble)sign * (npy_longdouble)mantissa[0];
    } else if (exp == LDBL_MAX_EXP && mantissa[0] == 0) {
        ld = (npy_longdouble)sign * ((npy_longdouble)mantissa[1] * powl(2.0L, (npy_longdouble)(exp - 64)) + 
            (npy_longdouble)mantissa[2] * powl(2.0L, (npy_longdouble)(exp - 128)));

diff --git a/numpy/_core/tests/test_longdouble.py b/numpy/_core/tests/test_longdouble.py
@@ -323,16 +323,20 @@ def test_fromstring_foreign_value(self):
 # 2^1023 + 2^1022 + ... + 2^970
 # largest number that can be stored in a double without loosing precision
 # Now gives an overflow error if te number is too big
+@pytest.mark.parametrize("sign", [1, -1])
 @pytest.mark.parametrize("int_val", [
-    2 ** 1023, 0, 10, 3, -(2 ** 1023), 15653215315])
-def test_longdouble_from_int(int_val):
+    2 ** 1023, 0, 10, 3, 15653215315, 5511, 644861])
+def test_longdouble_from_int(sign, int_val):
    # for issue gh-9968
+    int_val *= sign
    str_val = str(int_val)
    assert np.longdouble(int_val) == np.longdouble(str_val)

+@pytest.mark.parametrize("sign", [1, -1])
 @pytest.mark.parametrize("int_val", [
-    1000, 1815361, 358165, 646153161, 1, 0])
-def test_longdouble_from_int_rounding(int_val):
+    1000, 1815361, 358165, 646153161, 1])
+def test_longdouble_from_int_rounding(sign, int_val):
+    int_val *= sign
    flt_val = float(int_val)
    assert np.isclose(np.longdouble(int_val), flt_val)