Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

TYP: fix string-like ndarray rich comparison operators #28717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

jorenham
Copy link
Member

This fixes <, <=, >, and >= for ndarray instances with bytes_, str_, or StringDType dtypes, and closes #28708.

@jorenham jorenham added 09 - Backport-Candidate PRs tagged should be backported 41 - Static typing labels Apr 15, 2025
@jorenham
Copy link
Member Author

cc @MarcoGorelli

@charris charris merged commit 3d01f64 into numpy:main Apr 15, 2025
75 checks passed
@charris
Copy link
Member

charris commented Apr 15, 2025

Thanks Joren.

@jorenham jorenham deleted the typing/fix-28708 branch April 15, 2025 21:07
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TYP: false positive when using __ge__ between NDArray[np.str_]
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.