TYP: Type MaskedArray.__{ge,gt,le,lt}__
#28689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
reviewed
Apr 11, 2025
numpy/ma/core.pyi
Outdated
Comment on lines
438
to
447
| @overload | ||
| def __ge__(self: _MaskedArrayNumber_co, other: _ArrayLikeNumber_co, /) -> _MaskedArray[bool_]: ... | ||
| @overload | ||
| def __ge__(self: _MaskedArrayTD64_co, other: _ArrayLikeTD64_co, /) -> _MaskedArray[bool_]: ... | ||
| @overload | ||
| def __ge__(self: _MaskedArray[datetime64], other: _ArrayLikeDT64_co, /) -> _MaskedArray[bool_]: ... | ||
| @overload | ||
| def __ge__(self: _MaskedArray[object_], other: Any, /) -> _MaskedArray[bool_]: ... | ||
| @overload | ||
| def __ge__(self: _MaskedArray[Any], other: _ArrayLikeObject_co, /) -> _MaskedArray[bool_]: ... |
There was a problem hiding this comment.
>>> np.ma.array([""]) >= np.ma.array([""])
masked_array(data=[ True],
mask=False,
fill_value=True)
>>> np.ma.array([b""]) >= np.ma.array([b""])
masked_array(data=[ True],
mask=False,
fill_value=True)
>>> np.ma.array([b""]) >= np.ma.array([""])
Traceback (most recent call last):
File "<python-input-15>", line 1, in <module>
np.ma.array([b""]) >= np.ma.array([""])
File "/home/joren/.pyenv/versions/3.13.3/lib/python3.13/site-packages/numpy/ma/core.py", line 4308, in __ge__
return self._comparison(other, operator.ge)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
File "/home/joren/.pyenv/versions/3.13.3/lib/python3.13/site-packages/numpy/ma/core.py", line 4241, in _comparison
check = compare(sdata, odata)
numpy._core._exceptions._UFuncNoLoopError: ufunc 'greater_equal' did not contain a loop with signature matching types (<class 'numpy.dtypes.BytesDType'>, <class 'numpy.dtypes.StrDType'>) -> None
>>> np.ma.array([""]) >= np.ma.array([""], dtype=np.dtypes.StringDType)
masked_array(data=[ True],
mask=False,
fill_value=True)so dtype[str_] | StringDType, dtype[str_] | StringDType and dtype[bytes_], dtype[bytes_] will also work, as long as you don't mix bytes_ and string-y dtypes.
I didn't check void yet, but I'm guessing that void, void will also work at runtime.
There was a problem hiding this comment.
Btw, I also wouldn't mind if you leave out the overloads and simply accept other: ArrayLike for all self, in case you feel like this is getting too complex (
There was a problem hiding this comment.
thanks for your review!
i'll note that this is also an issue for ndarray, have opened a separate issue about it: #28708
Sure, happy to use other: ArrayLike then
jorenham
approved these changes
Apr 15, 2025
MaskedArray.__ge__MaskedArray.__{ge,gt,le,lt}__
30 tasks
|
Thanks Marco |
VascoConceicao
pushed a commit
to VascoConceicao/numpy
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's quite a few binary operations which are probably quite similar to type, I figured I'd start with checking we can get
__ge__right, then a few more can follow straightforwardly