fix quantile all zeros error

numpy · galio1237 · Mar 27, 2025 · Mar 27, 2025 · 1dbd18016ce355a1feef40a4335dd1284e6442b9 · tylerjereddy
commit 1dbd18016ce355a1feef40a4335dd1284e6442b9
diff --git a/numpy/lib/_function_base_impl.py b/numpy/lib/_function_base_impl.py
@@ -4537,6 +4537,8 @@ def quantile(a,
        weights = _weights_are_valid(weights=weights, a=a, axis=axis)
        if np.any(weights < 0):
            raise ValueError("Weights must be non-negative.")
+        if np.all(weights == 0):
+            raise ValueError("Weights must contain non-zero value.")

    return _quantile_unchecked(
        a, q, axis, out, overwrite_input, method, keepdims, weights)

diff --git a/numpy/lib/tests/test_function_base.py b/numpy/lib/tests/test_function_base.py
@@ -4110,6 +4110,13 @@ def test_quantile_weights_raises_negative_weights(self):
        with pytest.raises(ValueError, match="Weights must be non-negative"):
            np.quantile(y, 0.5, weights=w, method="inverted_cdf")

+    def test_quantile_weights_raises_all_zeros_weights(self):
+        y = [1, 2]
+        w = [0, 0]
+        with pytest.raises(ValueError, match="Weights must contain non-zero value."):
+            np.quantile(y, 0.5, weights=w, method="inverted_cdf")
+
+
    @pytest.mark.parametrize(
            "method",
            sorted(set(quantile_methods) - set(methods_supporting_weights)),
-Original file line number
+Diff line change
@@ -4110,6 +4110,13 @@ def test_quantile_weights_raises_negative_weights(self):
             with pytest.raises(ValueError, match="Weights must be non-negative"):
                 np.quantile(y, 0.5, weights=w, method="inverted_cdf")
+        def test_quantile_weights_raises_all_zeros_weights(self):
+            y = [1, 2]
+            w = [0, 0]
+            with pytest.raises(ValueError, match="Weights must contain non-zero value."):
+                np.quantile(y, 0.5, weights=w, method="inverted_cdf")
             Copy link

  
      
    
  

  
      

  
    Contributor


      

  

  
    
      

      
            tylerjereddy
  

      

      

      


        Mar 28, 2025


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      
Could someone please provide guidance on the reasons for these failures and suggest steps to address them?

You can reproduce the linter failure observed in CI locally by running spin lint on your branch. Purging the extra blank line it complains about will allow spin lint to pass locally and in CI. I checked the full test suite locally on this branch and it seems "ok."
The Qemu job failure in CI is clearly unrelated so don't worry about that.
For bug fixes, we usually prefix commits and titles of PRs with BUG:. You can find the list of prefixes in our docs.
Note for other NumPy devs--gh-28594 is very similar to this.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
         @pytest.mark.parametrize(
                 "method",
                 sorted(set(quantile_methods) - set(methods_supporting_weights)),
-          Expand Down