Modified tests and added release note

numpy · Tontonio3 · Mar 27, 2025 · Mar 27, 2025 · Mar 27, 2025 · Mar 27, 2025
commit ae8cd54d289196ea2c4af8b7e6748a9d2cf87d89
diff --git a/doc/release/upcoming_changes/28589.improvement.rst b/doc/release/upcoming_changes/28589.improvement.rst
@@ -0,0 +1,7 @@
+Improved error handling in `np.quantile`
+---------------------------------
+`np.quantile` now raises errors if:
+
+* All weights are zero
+* At least one weight is `np.nan`
+* At least one weight is `np.inf`
diff --git a/numpy/lib/tests/test_function_base.py b/numpy/lib/tests/test_function_base.py
@@ -4151,20 +4151,16 @@ def test_inf_err(self):

        for i in range(len(arr)):
            wgt[i] = np.inf
-            try:
+            with pytest.raises(ValueError) as ex:
                a = np.quantile(arr, q, weights=wgt, method=m)
-            except Exception as ex:
-                assert ex.__class__ == ValueError
-                assert str(ex) == "Weights must be non-infinite"
+            assert str(ex) == "Weights must be non-infinite"
            wgt[i] = 1

        for i in range(len(arr)):
            wgt[i] = np.inf
-            try:
+            with pytest.raises(ValueError) as ex:
                a = np.quantile(arr, q, weights=wgt, method=m)
-            except Exception as ex:
-                assert ex.__class__ == ValueError
-                assert str(ex) == "Weights must be non-infinite"
+            assert str(ex) == "Weights must be non-infinite"

    def test_nan_err(self):

@@ -4175,32 +4171,26 @@ def test_nan_err(self):

        for i in range(len(arr)):
            wgt[i] = np.nan
-            try:
+            with pytest.raises(ValueError) as ex:
                a = np.quantile(arr, q, weights=wgt, method=m)
-            except Exception as ex:
-                assert ex.__class__ == ValueError
-                assert str(ex) == "At least one weight is nan"
+            assert str(ex) == "At least one weight is nan"
            wgt[i] = 1

        for i in range(len(arr)):
            wgt[i] = np.nan
-            try:
+            with pytest.raises(ValueError) as ex:
                a = np.quantile(arr, q, weights=wgt, method=m)
-            except Exception as ex:
-                assert ex.__class__ == ValueError
-                assert str(ex) == "At least one weight is nan"
+            assert str(ex) == "At least one weight is nan"

    def test_all_zeroes_err(self):

        m = "inverted_cdf"
        q = 0.5
        arr = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
        wgt = np.zeros(10)
-        try:
+        with pytest.raises(ValueError) as ex:
            a = np.quantile(arr, q, weights=wgt, method=m)
-        except Exception as ex:
-            assert ex.__class__ == ValueError
-            assert str(ex) == "At least one weight must be non-zero"
+        assert str(ex) == "At least one weight must be non-zero"


 class TestLerp: