Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

TYP: stub random._pickle #28452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2025
Merged

TYP: stub random._pickle #28452

merged 3 commits into from
Mar 8, 2025

Conversation

guan404ming
Copy link
Member

@guan404ming guan404ming commented Mar 8, 2025 •
edited
Loading

@guan404ming guan404ming changed the title TYPE: add random._pickle.pyi TYPE: Add random._pickle.pyi Mar 8, 2025
@jorenham jorenham changed the title TYPE: Add random._pickle.pyi TYP: Add random._pickle.pyi Mar 8, 2025
@jorenham
Copy link
Member

jorenham commented Mar 8, 2025

I believe the new .pyi needs to be included here:

numpy/numpy/random/meson.build

Lines 95 to 116 in f978112

# Install Python sources, stub files, tests, examples and license
# ---------------------------------------------------------------
py.install_sources(
[
'__init__.pxd',
'__init__.py',
'__init__.pyi',
'_common.pxd',
'_generator.pyi',
'_mt19937.pyi',
'_pcg64.pyi',
'_pickle.py',
'_philox.pyi',
'_sfc64.pyi',
'bit_generator.pxd',
'bit_generator.pyi',
'c_distributions.pxd',
'LICENSE.md',
'mtrand.pyi',
],
subdir: 'numpy/random'
)

@jorenham jorenham added the numtype Isssue/PR related to numpy/numtype label Mar 8, 2025
@guan404ming
Copy link
Member Author

guan404ming commented Mar 8, 2025 •
edited
Loading

Updated, thanks @jorenham~

jorenham
jorenham reviewed Mar 8, 2025
View reviewed changes
numpy/random/meson.build Outdated Show resolved Hide resolved
@guan404ming guan404ming changed the title TYP: Add random._pickle.pyi TYP: stub random._pickle Mar 8, 2025
@jorenham jorenham changed the title TYP: stub random._pickle TYP: stub random._pickle Mar 8, 2025
@jorenham jorenham merged commit ede4009 into numpy:main Mar 8, 2025
71 checks passed
@jorenham
Copy link
Member

jorenham commented Mar 8, 2025

Thanks, Guan-Ming!

@charris charris added 09 - Backport-Candidate PRs tagged should be backported and removed 09 - Backport-Candidate PRs tagged should be backported labels Mar 8, 2025
charris pushed a commit to charris/numpy that referenced this pull request Mar 14, 2025
@guan404ming @charris
TYP: stub random._pickle (numpy#28452)
7d567aa 
* Add random._pickle.pyi

* Add new file in meson.build

* Align style in numpy/random/meson.build
@charris charris mentioned this pull request Mar 14, 2025
Merged
charris added a commit that referenced this pull request Mar 14, 2025
@charris
Merge pull request #28512 from charris/backport-28452-28491-28494
fe43f38 
TYP: Typing fixes backported from #28452, #28491, #28494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorenham jorenham jorenham approved these changes

Assignees
No one assigned
Labels
41 - Static typing numtype Isssue/PR related to numpy/numtype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guan404ming @jorenham @charris
Morty Proxy This is a proxified and sanitized view of the page, visit original site.