BUG: Fix crackfortran parsing error when a division occurs within a common block #28396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nchristensen - can you add a test for this? Thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
|
I had to simplify the example code, but the test seems to work now. |
|
I don't think the test failure is related. Ping @HaoZeke - would you mind taking a look at this? |
|
@HaoZeke ping. |
HaoZeke
requested changes
Mar 25, 2025
There was a problem hiding this comment.
Thanks @nchristensen. I have an enhancement suggestion but otherwise this looks like a pragmatic solution.
HaoZeke
approved these changes
Apr 2, 2025
|
Please squash when merging. |
|
Thanks @nchristensen . |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Apr 2, 2025
…ommon block (numpy#28396) * BUG: Fix crackpython parsing error when a division occurs within a common block * Add test for more complicated array sizing expression * fix typos * Simplify tests to currently supported syntax * Use regular expression to find common block name * Revert from broken regular expression version to prior version, add comment * Add space before inline comment * Use regular expression to split line * Add missing white space to appease linter * More linting fixes * Pass maxsplit as a keyword argument
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
Apr 11, 2025
…ommon block (numpy#28396) * BUG: Fix crackpython parsing error when a division occurs within a common block * Add test for more complicated array sizing expression * fix typos * Simplify tests to currently supported syntax * Use regular expression to find common block name * Revert from broken regular expression version to prior version, add comment * Add space before inline comment * Use regular expression to split line * Add missing white space to appease linter * More linting fixes * Pass maxsplit as a keyword argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
analyzelinefunction currently passes over all/characters, presumably assuming they only indicate the name of the common block. However, this means division operations after the common block name are also passed over.For instance
common /mortmp/ ctmp((lub*(lub+1)*(lub+1))/lpmin+1)fails to parse correctly.
This pull request attempts to rectify this by counting the number of slashes encountered in the line and only passing over the first two.