Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

BUG: Make np.nonzero threading safe #28361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 22, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cleanup
  • Loading branch information
eendebakpt committed Feb 22, 2025
commit d1c7b4a6e32a7dc6fa61d92cb9102304e1f5e5db
5 changes: 1 addition & 4 deletions 5 .github/workflows/compiler_sanitizers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,8 @@ jobs:
python -m spin build -j2 -- -Db_sanitize=thread
- name: Test
run: |
# try to figure out root folder for source
echo $HOME
set
# These tests are slow, so only run tests in files that do "import threading" to make them count
TSAN_OPTIONS="allocator_may_return_null=1:suppressions=/Users/runner/work/numpy/numpy/tools/ci/tsan_suppressions.txt" \
TSAN_OPTIONS="allocator_may_return_null=1:suppressions=$GITHUB_WORKSPACE/tools/ci/tsan_suppressions.txt" \
python -m spin test \
`find numpy -name "test*.py" | xargs grep -l "import threading" | tr '\n' ' '` \
-- -v -s --timeout=600 --durations=10
4 changes: 0 additions & 4 deletions 4 tools/ci/tsan_suppressions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@
#
# Reference: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions


# These warnings trigger directly in a CPython function.

# For np.nonzero, see gh-28361
#race:lowlevel_strided_loops.c.src
race:PyArray_Nonzero
race:count_nonzero_int
race:count_nonzero_bool
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.