Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

BUG: fix race initializing legacy dtype casts #28321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 11, 2025
Merged

BUG: fix race initializing legacy dtype casts #28321

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
de08196
BUG: fix race initializing legacy dtype casts
ngoldbaum Feb 6, 2025
ebb0a85
CI: remove pytest-xdist from TSAN and ASAN CI python env
ngoldbaum Feb 6, 2025
036d7d5
BUG: fix logic error in ensure_castingimpl_exists
ngoldbaum Feb 6, 2025
73698cf
BUG: fix data race setting up within dtype cats for legacy user dtypes
ngoldbaum Feb 6, 2025
e5411a3
MAINT: spawn fewer threads to hopefully fix 32 bit runners
ngoldbaum Feb 6, 2025
f3c47ac
BUG: fix reference counting error
ngoldbaum Feb 7, 2025
67f0402
BUG: fix resource cleanup when thread spawning errors
ngoldbaum Feb 7, 2025
425d162
MAINT: refactor run_threaded to use a try/finally block
ngoldbaum Feb 7, 2025
cac1f10
MAINT: clean up slightly
ngoldbaum Feb 7, 2025
e6f581d
MAINT: fix linter
ngoldbaum Feb 7, 2025
3f8fbd6
MAINT: go back to try/except
ngoldbaum Feb 7, 2025
d494647
MAINT: fix indentation and clarify comment
ngoldbaum Feb 7, 2025
c20ac88
MAINT: use a try/finally to make the deadlock protection more robust
ngoldbaum Feb 8, 2025
96ca7e3
MAINT: respond to code review
ngoldbaum Feb 11, 2025
48515a3
MAINT: Update some testing files from main
charris Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MAINT: spawn fewer threads to hopefully fix 32 bit runners
  • Loading branch information
@ngoldbaum @charris
ngoldbaum authored and charris committed Feb 11, 2025
commit e5411a3acd54008ec30fd7a59c1c1fb505a1dc2c
2 changes: 1 addition & 1 deletion 2 numpy/_core/tests/test_multithreading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,4 +260,4 @@ def closure(b):
b.wait()
np.full((10, 10), 1, _rational_tests.rational)

run_threaded(closure, 1000, pass_barrier=True)
run_threaded(closure, 250, pass_barrier=True)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.