Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

ENH: support no-copy pickling for any array that can be transposed to a C-contiguous array #28105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
May 14, 2025
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
0dcde49
add support for transposed contiguous array and corresponding test
IndifferentArea Jan 6, 2025
a27f5eb
Merge branch 'numpy:main' into GH-26878
IndifferentArea Jan 6, 2025
50be134
fix lint
IndifferentArea Jan 6, 2025
7cea83c
rm bad includes
IndifferentArea Jan 6, 2025
bf5ecaa
fix
IndifferentArea Jan 6, 2025
a566660
fix
IndifferentArea Jan 6, 2025
63da2b9
discard vla
IndifferentArea Jan 6, 2025
9494672
accept legacy pkl
IndifferentArea Jan 9, 2025
6b9421a
check return
IndifferentArea Jan 9, 2025
6ca72f1
fix ci
IndifferentArea Jan 9, 2025
0f70349
check after transpose
IndifferentArea Jan 9, 2025
c045bd9
discard auto include
IndifferentArea Jan 9, 2025
aa357a9
use N format in pybuildvalue
IndifferentArea Jan 10, 2025
aee895b
use pytuple pack
IndifferentArea Jan 10, 2025
1b2f9d6
clean up
IndifferentArea Jan 10, 2025
4a16cd3
add comment on fall back behavior
IndifferentArea Jan 10, 2025
449ea59
add mroe test
IndifferentArea Jan 10, 2025
f0d528a
use byte str instead of pkl to test
IndifferentArea Jan 10, 2025
a8cc7fc
get shape with pyarray api
IndifferentArea Jan 10, 2025
5f88eb3
fmt
IndifferentArea Jan 10, 2025
4ba4c55
better comment
IndifferentArea Jan 10, 2025
de8899a
fix as suggested
IndifferentArea Jan 10, 2025
4be8c0c
fix lint
IndifferentArea Jan 10, 2025
e8ddf99
discard auto include
IndifferentArea Jan 10, 2025
3ee9178
shorter tested strs
IndifferentArea Jan 13, 2025
4783c41
fmt
IndifferentArea Jan 13, 2025
d2a8306
last correct commit
IndifferentArea Jan 13, 2025
94a297a
last correct commit
IndifferentArea Jan 13, 2025
e17acbc
[skip ci] memory leak
IndifferentArea Jan 13, 2025
7fd5037
add cleanup
IndifferentArea Jan 13, 2025
16e7067
[skip ci] add release doc
IndifferentArea Jan 13, 2025
7982184
[skip ci] add check for pylong_fromlong
IndifferentArea Jan 13, 2025
d635e65
typo
IndifferentArea Jan 13, 2025
aaa9b9f
fix memory leak
IndifferentArea Jan 14, 2025
ecb863f
more clean up
IndifferentArea Jan 14, 2025
bfbde0e
use same random seed
IndifferentArea Jan 27, 2025
35ea29f
use xdecref
IndifferentArea Jan 27, 2025
596db8c
check PyArray_Transpose
IndifferentArea Jan 27, 2025
1a82f4e
check PyArray_IntTupleFromIntp
IndifferentArea Jan 27, 2025
80ba96d
fix
IndifferentArea Feb 2, 2025
792468a
once-over
IndifferentArea Feb 2, 2025
c213b37
add additional test
IndifferentArea Feb 2, 2025
3174d5e
once over again
IndifferentArea Feb 2, 2025
43e214a
fmt
IndifferentArea Mar 26, 2025
42e1c99
pickle format consistency
IndifferentArea Mar 26, 2025
f71549f
fix incorrect usage of cpy api
IndifferentArea Mar 26, 2025
d5c2215
fmt
IndifferentArea Mar 26, 2025
8b981dc
Merge branch 'main' into GH-26878
IndifferentArea Mar 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
IndifferentArea committed Mar 26, 2025
commit d5c2215d608c52efa358716bcbd258fa0a753e94
2 changes: 1 addition & 1 deletion 2 numpy/_core/src/multiarray/methods.c
Original file line number Diff line number Diff line change
Expand Up @@ -1885,7 +1885,7 @@ array_reduce_ex_picklebuffer(PyArrayObject *self, int protocol)
* of the initial array, that is C-contiguous. */
order = 'F';
transposed_array = PyArray_Transpose((PyArrayObject *)self, NULL);
ngoldbaum marked this conversation as resolved.
Show resolved Hide resolved
if(transposed_array == NULL) {
if (transposed_array == NULL) {
return NULL;
}
}
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.