Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DOC: Fix sphinx markup in source/reference/random/extending.rst #28101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

WarrenWeckesser
Copy link
Member

Change :start-after: dlopen to :start-at: dlopen so the line containing the call of ffi.dlopen() is included.

Change ':start-after: dlopen' to ':start-at: dlopen' so the line
containing the call of 'ffi.dlopen()' is included.

[skip actions] [skip azp] [skip cirrus]
@WarrenWeckesser
Copy link
Member Author

The corrected output can be seen at CFFI, where the line

lib = ffi.dlopen(np.random._generator.__file__)

is now included at the start of the second block of code.

@mattip mattip merged commit 2eccb5e into numpy:main Jan 5, 2025
5 checks passed
@mattip
Copy link
Member

mattip commented Jan 5, 2025

Thanks @WarrenWeckesser

@WarrenWeckesser WarrenWeckesser deleted the doc-fix-extending-cffi branch January 5, 2025 11:26
ArvidJB added a commit to ArvidJB/numpy that referenced this pull request Jan 8, 2025
Update the `np.strings.slice` docstrings to follow convention
and correctly split between argument type and documentation.

Also update the `slice` release note to follow convention for
new functions.

Lastly, fix the gcc version upgrade PR reference from numpy#28101
to numpy#28102.
ArvidJB added a commit to ArvidJB/numpy that referenced this pull request Jan 8, 2025
Update the `np.strings.slice` docstrings to follow convention
and correctly split between argument type and documentation.

Also update the `slice` release note to follow convention for
new functions.

Lastly, fix the gcc version upgrade PR reference from numpy#28101
to numpy#28102.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.