MAINT: Fix cirrus MacOs wheel builds [wheel build] #27930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs backport to 2.1.x. |
|
@rgommers We are building some macos wheels with openblas, I assume for older versions of macos. Do we want to keep supporting those? |
|
macOS wheels are a bit complicated. Before macOS 14 use of openblas is necessary because Accelerate BLAS wasn't adequate. I assume we'll need to make these wheels until macos13 is no longer relevant. |
|
I did see the failures on an earlier commit in that PR and figured it was unrelated. Thanks for looking into it. |
|
This looks to be passing now. |
Merged
Yes, that is right. It'll be a while before we can drop those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andyfaff Ping. This started failing last week. See https://cirrus-ci.com/build/5843049672081408.
@ngoldbaum You didn't see this failure in #27899 because the added commits did not have [wheel build] in the title line.