ENH: add matvec and vecmat gufuncs #27846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25675.
This PR adds new
matvec
andvecmat
gufunc to calculate the matrix-vector and vector-matrix product, to add to plain matrix multiplication withmatmul
and the inner vector product withvecdot
.Fixes #12348
Note that for complex numbers,
vecmat
is defined asx†A
, i.e., the complex conjugate of the vector is taken. This seems to be the standard and is what we used forvecdot
too (x†x
). However, it is not whatmatmul
does for vector-matrix or indeed vector-vector products. I think this is a bug in matmul, which I'm happy to fix here. But I'll post to the mailing list to get feedback.Separately, with these functions available, in principle these could be used in
__matmul__
and the specializations innp.matmul
removed. But that can be a separate PR (if it is wanted at all).Summary of mailing list discussion
np.matmul
for vector-matrix should not be adjusted. Some surprise that "matrix multiplcation" deals with vectors at all.@
should do.matvec
andvecmat
functions.