ENH: Ensure hugepages are also indicated for calloc allocations #27808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On linux we madvise hugepages for large malloc allocations but fail to do so also for calloc allocations even though it makes just as much sense there. This aligns the two code paths.
|
Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On linux we madvise hugepages for large malloc allocations but fail to do so also for calloc allocations even though it makes just as much sense there.
This aligns the two (or rather three) code paths.
Closes gh-27483
I have run the test from the issue on a linux machine, and see a clear drop for the first write into the huge array (going down to be same as empty in this case, which I didn't even quite expect).