Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

BUG: Allow empty memmaps in most situations #27723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 18, 2024
Merged

BUG: Allow empty memmaps in most situations #27723

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ced32b7
BUG: error empty memmap offset is a multiple of allocation granularity
Nov 8, 2024
0a141cd
DOC: added a code comment explaining issue with `bytes==0` in memmap
Nov 13, 2024
ef2fefb
TST: test for arr.offset being correct
Nov 13, 2024
698ce79
ENH: allow empty memmap
Nov 13, 2024
2c803f8
TST: adjust test for empty memmap
Nov 13, 2024
588bed6
STY: numpy/_core/tests/test_memmap.py
laarohi Nov 18, 2024
2684626
STY: Update numpy/_core/tests/test_memmap.py
laarohi Nov 18, 2024
9acace7
STY: Update numpy/_core/tests/test_memmap.py
laarohi Nov 18, 2024
99b7afa
TST: Update numpy/_core/tests/test_memmap.py
laarohi Nov 18, 2024
a9f30c7
DOC: added enhancement release note for gh-27723
Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
STY: Update numpy/_core/tests/test_memmap.py 
Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
  • Loading branch information
@laarohi @seberg
laarohi and seberg authored Nov 18, 2024
commit 9acace7d52e864a67695e956003119e42ad56e4c
2 changes: 1 addition & 1 deletion 2 numpy/_core/tests/test_memmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def test_empty_array(self):

self.tmpfp.write(b'\0')
laarohi marked this conversation as resolved.
Show resolved Hide resolved
# ok now the file is not empty
memmap(self.tmpfp, shape=(0,4), mode='w+')
memmap(self.tmpfp, shape=(0, 4), mode='w+')

def test_shape_type(self):
memmap(self.tmpfp, shape=3, mode='w+')
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.