BUG: np.cov transpose control #27661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this have a chance of breaking existing (bad) code in odd ways? (I.e. should we add a release note and consider probably not backport?) |
|
The bug has existed for 19 years (I tracked the behavior to 959f36c via |
|
I agree, let's add a release note and then merge this. |
* Fixes numpy#27658 * Use a more sensible filter for controlling the decision to transpose the design matrix received by `np.cov`. * Add a release note.
ea81e9c to
e003e82
Compare
|
Ok, I added a release note/towncrier fragment (amending the original commit since the diff is so small here). The release note looks like this locally via
|
|
Thanks Tyler and Jake! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BUG: np.cov with rowvar=False returns the wrong shape for N=1 #27658
Use a more sensible filter for controlling the decision to transpose the design matrix received by
np.cov.