Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

BUG: Adjust numpy.i for SWIG 4.3 compatibility #27593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

charris
Copy link
Member

@charris charris commented Oct 18, 2024

Backport of #27579.

Replace each SWIG_Python_AppendOutput with SWIG_AppendOutput.

Fixes #27578.

See #27578 for context. From SWIG upstream:

2024-06-15: vadz
            [Python] #2907 Fix returning null from functions with output
            parameters.  Ensures OUTPUT and INOUT typemaps are handled
            consistently wrt return type.

            New declaration of SWIG_Python_AppendOutput is now:

              SWIG_Python_AppendOutput(PyObject* result, PyObject* obj, int is_void);

            The 3rd parameter is new and the new $isvoid special variable
            should be passed to it, indicating whether or not the wrapped
            function returns void.

            Also consider replacing with:

              SWIG_AppendOutput(PyObject* result, PyObject* obj);

            which calls SWIG_Python_AppendOutput with same parameters but adding $isvoid
            for final parameter.

	    *** POTENTIAL INCOMPATIBILITY ***

I don’t understand SWIG very well, so I’ve assumed that a blind search-and-replace of SWIG_Python_AppendOutput with SWIG_AppendOutput at least does not make anything worse! Review by someone more familiar with SWIG would be welcome.

See also related discussion on the Swig-devel mailing list.

Replace each `SWIG_Python_AppendOutput` with `SWIG_AppendOutput`.

Fixes numpy#27578.
@charris charris added 00 - Bug 08 - Backport Used to tag backport PRs labels Oct 18, 2024
@charris charris added this to the 2.1.3 release milestone Oct 18, 2024
@charris charris merged commit 3164928 into numpy:maintenance/2.1.x Oct 19, 2024
65 checks passed
@charris charris deleted the backport-27579 branch October 19, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
00 - Bug 08 - Backport Used to tag backport PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.