BUG: Fix user dtype can-cast with python scalar during promotion #27534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The can-cast code for "Python scalars" was old and did not correctly take into account possible user-dtypes with respect to NEP 50 weak promotion. To do this, we already had the necessary helper functions that go via promotion (although it took me some brooding to remember ;)). So the fix is rather simple. Actually adding CI/test for the fix is unfortunately hard as it requires such a user DType.
|
Let's give it a shot, we learn more when it is used. Thanks Sebastian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The can-cast code for "Python scalars" was old and did not correctly take into account possible user-dtypes with respect to NEP 50 weak promotion.
To do this, we already had the necessary helper functions that go via promotion (although it took me some brooding to remember ;)).
So the fix is rather simple. Actually adding CI/test for the fix is unfortunately hard as it requires such a user DType.
Closes gh-27389
@jakevdp while annoying, I am not certain that it is worth adding yet another (or multiple) user-dtypes to NumPy just to test this branch. Do you think
ml_typescovers it quite well for the time being?