TYP: Optional 2nd numpy.complexfloating type parameter
#27420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to avoid touching |
|
@charris I honestly have no idea why this keeps happening... Perhaps some vscode plugin that's being "helpful" 🤷🏻♂️ edit: I now suspect that it was indeed a missing |
6fb2354 to
df80b37
Compare
|
Just to note the |
|
Thanks @jorenham . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
complexfloating[N1, N2]tocomplexfloating[N1, N2 = N1](see PEP 696), so that static type-checkers will interpretcomplexfloating[N]ascomplexfloating[N, N].The runtime behavior already allows for passing a single type-argument to
complexfloating.edit
Because of some mypy bug related to PEP 696, the
complexfloatingoperator methods have inlined, which (how some reason) causes the bug to not be an issue anymore.