Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

MAINT: increase max line length from 79 to 88, upgrade pycodestyle #27320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2024
Merged

MAINT: increase max line length from 79 to 88, upgrade pycodestyle #27320

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88c68f9
MAINT: increase max line length from 79 to 88
DimitriPapadopoulos Sep 1, 2024
d30ca3e
MAINT: Bump pycodestyle from 2.8.0 to 2.12.1
DimitriPapadopoulos Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
MAINT: increase max line length from 79 to 88 
There are of course pros and cons, and PEP 8 still recommends 79. However,
lots of tools and recommendations have increased max line length:
- black and ruff have bumped the limit to 88,
- the Linux kernel coding style eventualy bumped the recommended limit from
  80 to 100 characters.

Also, the current codebase contains > 1880 lines wider than 79, against
around 500 lines wider than 88.
  • Loading branch information
@DimitriPapadopoulos
DimitriPapadopoulos committed Sep 1, 2024
commit 88c68f95f924be355da742d355ad0be0287ac327
2 changes: 1 addition & 1 deletion 2 tools/lint_diff.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[pycodestyle]
max_line_length = 79
max_line_length = 88
statistics = True
ignore = E121,E122,E123,E125,E126,E127,E128,E226,E241,E251,E265,E266,E302,E402,E704,E712,E721,E731,E741,W291,W293,W391,W503,W504
exclude = numpy/__config__.py,numpy/typing/tests/data,.spin/cmds.py
Morty Proxy This is a proxified and sanitized view of the page, visit original site.