Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

BLD: cp313 cp313t linux_aarch64 [wheel build] #27110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Conversation

andyfaff
Copy link
Member

@andyfaff andyfaff commented Aug 4, 2024

cp313+cp313t builds for linux_aarch64.

@github-actions github-actions bot added the 36 - Build Build related PR label Aug 4, 2024
@charris
Copy link
Member

charris commented Aug 4, 2024

Hmm, there is some problem with 313t on aarch64. There is also a nightly build of musllinux for aarch64 for earlier Python, but I don't see where that is located. @mattip I believe you were experimenting with that using a newer musl version?

@andyfaff
Copy link
Member Author

andyfaff commented Aug 5, 2024

It might just need an environment variable to be set.

@ngoldbaum
Copy link
Member

If you don't want to work on the free-threaded wheel, just disable it for now and I'll work on adding it in a followup.

@ngoldbaum
Copy link
Member

The thing you're missing from the github actions config for free-threaded wheels is this bit:

      - name: Set up free-threaded build
        if: matrix.python == 'cp313t'
        run: |
          echo "CIBW_BUILD_FRONTEND=pip; args: --no-build-isolation" >> "$GITHUB_ENV"

I'm not familiar with cirrus, but somehow you'll need to set that environment variable in the runner's shell environment, similar to the $GITHUB_ENV mechanism.

- env:
CIRRUS_CLONE_SUBMODULES: true
CIBW_BUILD: cp313t-*
CIBW_FREE_THREADED_SUPPORT: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just unconditionally set this variable to true on all builds if you don't want to duplicate the config.

@charris
Copy link
Member

charris commented Aug 5, 2024

If you don't want to work on the free-threaded wheel, just disable it for now

I'll probably just put this in as is if it isn't fixed soon, it looks fixable. @andyfaff I'm curious about the missing musllinux build for 3.13 on aarch64, do we need the new version of musl?

@charris charris added this to the 2.1.0 release milestone Aug 5, 2024
@charris
Copy link
Member

charris commented Aug 5, 2024

Cirrus offers the following example:

custom_path_task:
  env:
    SDK_ROOT: ${HOME}/sdk
    PATH: ${SDK_ROOT}/bin:${PATH}
  custom_script: sdktool install

@andyfaff
Copy link
Member Author

andyfaff commented Aug 5, 2024

I'm curious about the missing musllinux build for 3.13 on aarch64, do we need the new version of musl?

The linux_aarch64_task will build both the manylinux and musllinux wheels.

@charris
Copy link
Member

charris commented Aug 6, 2024

The 3.13t aarch64 build timed out, we might want to make the manylinux and musl builds separate tasks.

I've rerun it to see if that was a fluke.

@andyfaff
Copy link
Member Author

andyfaff commented Aug 6, 2024

I tried to tune the builds so they use a minimal set of resources, for cost. So we could either add another entry or bump CPUs/memory.

@charris charris merged commit 7533a4c into numpy:main Aug 6, 2024
107 of 109 checks passed
@charris
Copy link
Member

charris commented Aug 6, 2024

Thanks Andy, Nathan. The second run of the 3.13t build took 51 minutes, which might be shaving things a bit close, but the failure is fixable with a rerun.

@andyfaff andyfaff deleted the cp313 branch August 6, 2024 01:18
@ngoldbaum
Copy link
Member

Should the nightlies have shown up on the staging site? I don't see how to trigger builds for nightly wheels on cirrus.

@seberg
Copy link
Member

seberg commented Aug 7, 2024

Not sure how to trigger cirrus wheel builds (except by adding a one-off chron). I triggered the others manually today. Cirrus seems currently scheduled weekly on sunday only.
(I don't recall changing it back from bi-weekly, but I guess things slowed down.)

@charris
Copy link
Member

charris commented Aug 7, 2024

I don't see how to trigger builds

I don't know how to trigger a new build on cirrus either, but looked into it a bit once. IIRC, there needs to be in entry in the YML file to allow that.

@rgommers
Copy link
Member

rgommers commented Aug 7, 2024

It's a little fiddly on Cirrus - I go to the repo settings and change the cron config to trigger a build 2 minutes into the future, then change it back to the original schedule after the build succeeds. I think I've got the routine down now though. Don't we get RC builds anyway in hours to a day, now that the branch happened?

If you want me to do it let me know

@ngoldbaum
Copy link
Member

No worries, I just was curious why they hadn't shown up yet on the nightly wheel site.

I don't think it'll help much to have nightlies a day or two before the RC so I wouldn't go out of your way to set it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
36 - Build Build related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.