Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

MAINT: use an atomic load/store and a mutex to initialize the argparse and runtime import caches #26780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 12, 2024
Merged

MAINT: use an atomic load/store and a mutex to initialize the argparse and runtime import caches #26780

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e55b25c
TST: add a test to check if the argparse cache is thread safe
ngoldbaum May 13, 2024
6386423
MNT: lock initializing the argparse cache
ngoldbaum May 15, 2024
9a22d84
MNT: convert runtime imports to use single-initialization
ngoldbaum Jun 21, 2024
6ea18a4
MAINT: re-add libatomic link test to meson.build
ngoldbaum Jun 27, 2024
3c620cb
MAINT: add support for gcc builtin atomics
ngoldbaum Jun 27, 2024
2e2fa1d
MAINT: rework to use double-checked locking and avoid new struct
ngoldbaum Jul 4, 2024
b6af99a
BUG: fix windows build
ngoldbaum Jul 4, 2024
dabfe59
MAINT: respond to review comments
ngoldbaum Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BUG: fix windows build
  • Loading branch information
@ngoldbaum
ngoldbaum committed Jul 9, 2024
commit b6af99a05485d2a4bcc8436e5bebcb93d80872ee
2 changes: 1 addition & 1 deletion 2 numpy/_core/src/common/npy_atomic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#elif _MSC_VER
#include <intrin.h>
#define MSC_ATOMICS
#if !defined(_M_X64) || !defined(_M_IX86) || !defined(_M_ARM64)
#if !defined(_M_X64) && !defined(_M_IX86) && !defined(_M_ARM64)
#error "Unsupported MSVC build configuration, neither x86 or ARM"
#endif
#elif defined(__GNUC__) && (__GNUC__ > 4)
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.