Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

MAINT, BLD: Pin rtools to version 4.0 for Windows builds. #23720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2023

Conversation

charris
Copy link
Member

@charris charris commented May 5, 2023

Backports of #23678, #23715, #23716.

Windows 32 bit builds require rtools 4.0 but a recent upgrade has made 4.3 the default. This
PR pins the version used to 4.0

charris added 2 commits May 4, 2023 17:54
rtools 4.0 is no longer installed by default for GitHub actions and
versions greater than 4.1 do not support 32 bits, so explicitly include
the 4.0 version.

Closes numpy#23675
@charris charris added 03 - Maintenance 08 - Backport Used to tag backport PRs 36 - Build Build related PR labels May 5, 2023
@charris charris added this to the 1.24.4 release milestone May 5, 2023
@charris charris merged commit 87921fe into numpy:maintenance/1.24.x May 5, 2023
@charris charris deleted the backport-rtool-fixes branch May 11, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
03 - Maintenance 08 - Backport Used to tag backport PRs 36 - Build Build related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.