ENH,WIP: Adding "casting" keyword to close and equal functions in numeric (fix #17136) #18950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault casting rule is unsafe.
|
@lschwetlick Lint is unhappy. |
|
Yup, thanks for putting it on my radar :) We are still discussing other stuff that needs doing in this Issue thread #17136 . I'll work on it in the next few days! |
BvB93
reviewed
May 17, 2021
There was a problem hiding this comment.
I've got a couple of comments that apply to all functions changed within this PR.
Secondly, the annotation of the respective functions will have to be updated in the stub file: https://github.com/numpy/numpy/blob/main/numpy/core/numeric.pyi
By the looks of it something like this should suffice:
from numpy import _Casting # A string-`Literal` containing all valid casting kinds
def isclose(
a: ArrayLike,
b: ArrayLike,
rtol: float = ...,
atol: float = ...,
equal_nan: bool = ...,
casting: _Casting = ..., # The new keyword
) -> Any: ...Co-authored-by: Bas van Beek <43369155+BvB93@users.noreply.github.com>
Co-authored-by: Bas van Beek <43369155+BvB93@users.noreply.github.com>
Co-authored-by: Bas van Beek <43369155+BvB93@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #17136 , the functions
currently implicitly cast between data types without warning or error. Eg.:
In this PR we add the "casting" keyword to specify at which level inputs should be cast in the comparison. For example: