MAINT: Chain some exceptions. #16418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
May 29, 2020
eric-wieser
reviewed
May 29, 2020
|
Thanks for the patch! Everything looks great with the PR, just looks like I was unclear about how to choose between the two options in the tracking issue. |
numpy.ctypes and numpy.core
numpy.ctypes and numpy.core
rossbar
reviewed
May 29, 2020
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
|
Ok, I've implemented the feedback I've gotten. I also found some other places where I could fix the exceptions like this, should I just wait for this to be merged or should I keep working on this branch? |
1 task
rossbar
approved these changes
Jun 3, 2020
|
Thanks @zaak71 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #15986. I have modified a few files in the numpy and numpy/core folders to fit what has been requested here. This is my first PR on GitHub so if I did anything wrong please let me know. Thank you.