Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Propositions of test_umath_accuracy improvements #16115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
Loading
from

Conversation

panpiort8
Copy link
Contributor

It's not real PR, just some proposals. gh-15605

There are three main changes:

  • format of umath-validation-set-* files has changed
  • there are two scripts (not sure where to place them): first to generate data-sets from raw data and second to 'update' data-sets (renames test cases if necessary and checks if expected results are same as produced by mpmath)
  • test_umath_accuracy throws error with name of particular test case

But there are also some issues:

  • I don't now how to remove this ugly try catch (similar methods either are said to be less acurate or also have no error_message parameter):
try:
  assert_array_max_ulp(act, exp, maxulp=ulperr)
except:
  raise AssertionError('Nicely formatted error message')     
  • scripts like generate_umath_data.py should be included in numpy itself or somewhere on github?

@seberg
Copy link
Member

seberg commented May 4, 2020

@r-devulap would you have time to look at this PR and see if you like the changes, since the tests are originally your contribution?

@r-devulap
Copy link
Member

@seberg sure, I can take a look it.

Base automatically changed from master to main March 4, 2021 02:04
@HaoZeke HaoZeke requested a review from r-devulap June 8, 2022 18:56
@InessaPawson InessaPawson marked this pull request as draft June 24, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.