Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d34d1f3

Browse filesBrowse files
authored
Merge pull request #13108 from eric-wieser/simplify-vander-n-d
MAINT: Merge duplicate implementations of `hermvander2d` and `hermvander3d` functions
2 parents 58640b7 + b1c68f9 commit d34d1f3
Copy full SHA for d34d1f3

File tree

Expand file treeCollapse file tree

1 file changed

+2
-23
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-23
lines changed

‎numpy/polynomial/hermite.py

Copy file name to clipboardExpand all lines: numpy/polynomial/hermite.py
+2-23Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1291,17 +1291,7 @@ def hermvander2d(x, y, deg):
12911291
.. versionadded:: 1.7.0
12921292
12931293
"""
1294-
ideg = [int(d) for d in deg]
1295-
is_valid = [id == d and id >= 0 for id, d in zip(ideg, deg)]
1296-
if is_valid != [1, 1]:
1297-
raise ValueError("degrees must be non-negative integers")
1298-
degx, degy = ideg
1299-
x, y = np.array((x, y), copy=0) + 0.0
1300-
1301-
vx = hermvander(x, degx)
1302-
vy = hermvander(y, degy)
1303-
v = vx[..., None]*vy[..., None,:]
1304-
return v.reshape(v.shape[:-2] + (-1,))
1294+
return pu._vander2d(hermvander, x, y, deg)
13051295

13061296

13071297
def hermvander3d(x, y, z, deg):
@@ -1355,18 +1345,7 @@ def hermvander3d(x, y, z, deg):
13551345
.. versionadded:: 1.7.0
13561346
13571347
"""
1358-
ideg = [int(d) for d in deg]
1359-
is_valid = [id == d and id >= 0 for id, d in zip(ideg, deg)]
1360-
if is_valid != [1, 1, 1]:
1361-
raise ValueError("degrees must be non-negative integers")
1362-
degx, degy, degz = ideg
1363-
x, y, z = np.array((x, y, z), copy=0) + 0.0
1364-
1365-
vx = hermvander(x, degx)
1366-
vy = hermvander(y, degy)
1367-
vz = hermvander(z, degz)
1368-
v = vx[..., None, None]*vy[..., None,:, None]*vz[..., None, None,:]
1369-
return v.reshape(v.shape[:-3] + (-1,))
1348+
return pu._vander3d(hermvander, x, y, z, deg)
13701349

13711350

13721351
def hermfit(x, y, deg, rcond=None, full=False, w=None):

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.